Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sctransform recipe #512

Merged
merged 3 commits into from May 24, 2023
Merged

Update sctransform recipe #512

merged 3 commits into from May 24, 2023

Conversation

Sichao25
Copy link
Collaborator

  • Modified sctransform function and recipe. Now sctransform will only be performed on adata.X. Other layers will get normalized by size factors by default.
  • Users can run the sctransform on all layers manually, this will raise a warning.

@Sichao25 Sichao25 marked this pull request as ready for review May 19, 2023 21:39
@Xiaojieqiu
Copy link
Collaborator

thanks Sichao! this is great. Have you also implement the same procedure for pearson residual?

@Sichao25
Copy link
Collaborator Author

thanks Sichao! this is great. Have you also implement the same procedure for pearson residual?

Modification on person residuals is in another pull request. Also, the monocle_perason_residuals recipe has already implemented the correct way to perform the preprocessing.

@Xiaojieqiu Xiaojieqiu merged commit c9123ee into aristoteleo:master May 24, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants