Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug psl #573

Merged
merged 1 commit into from Oct 9, 2023
Merged

Debug psl #573

merged 1 commit into from Oct 9, 2023

Conversation

Sichao25
Copy link
Collaborator

@Sichao25 Sichao25 commented Aug 3, 2023

When we have an array like dist input, if not dist will regard it as a check on multiple values and then raise an error. What we need is if dist is None.

@codecov-commenter
Copy link

Codecov Report

Merging #573 (64d42bf) into master (7a45dec) will not change coverage.
The diff coverage is 0.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##           master     #573   +/-   ##
=======================================
  Coverage   22.32%   22.32%           
=======================================
  Files         158      158           
  Lines       26356    26356           
=======================================
  Hits         5885     5885           
  Misses      20471    20471           
Files Changed Coverage Δ
dynamo/tools/psl_py.py 13.33% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Sichao25 Sichao25 marked this pull request as ready for review August 4, 2023 22:10
@Xiaojieqiu Xiaojieqiu merged commit e44d325 into aristoteleo:master Oct 9, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants