Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug convert2symbol #603

Merged
merged 1 commit into from Nov 5, 2023
Merged

Debug convert2symbol #603

merged 1 commit into from Nov 5, 2023

Conversation

Sichao25
Copy link
Collaborator

@Sichao25 Sichao25 commented Nov 1, 2023

Bug description: When we query the information from mygene, the output won't contain the "notfound" column if all genes can be found in the mygene database. This will raise a KeyError.

Solution: When "notfound" is not in the output, use all indices as the valid_ind.

@Sichao25 Sichao25 marked this pull request as ready for review November 1, 2023 19:59
@Xiaojieqiu Xiaojieqiu merged commit 199d9b9 into aristoteleo:master Nov 5, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants