Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor VectorField() function #620

Merged
merged 8 commits into from
Feb 26, 2024
Merged

Conversation

Sichao25
Copy link
Collaborator

@Sichao25 Sichao25 commented Nov 28, 2023

  • Optimized the usage of SvcVectorField class in VectorField() function.
  • Created several helper functions to increase the readability of VectorField().
  • Remove the dynode_old method.
  • Moved VectorField() to a separate file VectorField.py.
  • Renamed VectorField2D/VectorField3D to Topography2D/Topography3D.

@codecov-commenter
Copy link

Codecov Report

Attention: 88 lines in your changes are missing coverage. Please review.

Comparison is base (e87f702) 22.17% compared to head (5d704e6) 22.27%.

Files Patch % Lines
dynamo/vectorfield/VectorField.py 56.99% 83 Missing ⚠️
dynamo/plot/topography.py 25.00% 3 Missing ⚠️
dynamo/vectorfield/topography.py 50.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #620      +/-   ##
==========================================
+ Coverage   22.17%   22.27%   +0.10%     
==========================================
  Files         166      167       +1     
  Lines       28032    28045      +13     
==========================================
+ Hits         6215     6248      +33     
+ Misses      21817    21797      -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sichao25 Sichao25 marked this pull request as ready for review November 28, 2023 20:51
@Xiaojieqiu
Copy link
Collaborator

@Sichao25 can you please fix this conflict?

@Xiaojieqiu Xiaojieqiu merged commit 67c7740 into aristoteleo:master Feb 26, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants