Rename const: DEFAULT_PREFIX => DEFAULT_NAMESPACE_PREFIX

aristov · Mar 7, 2018 · 2e5349f · 2e5349f
1 parent e8ab19a
commit 2e5349f
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 12 deletions.
diff --git a/lib/attr.js b/lib/attr.js
@@ -1,4 +1,4 @@
-import { DEFAULT_PREFIX, DEFAULT_NAMESPACE_URI, NAMESPACE_SEPARATOR } from './const'
+import { DEFAULT_NAMESPACE_PREFIX, DEFAULT_NAMESPACE_URI, NAMESPACE_SEPARATOR } from './const'
 import { ElementAssembler } from './element'
 import { NodeAssembler } from './node'
 
@@ -183,7 +183,7 @@ export class AttrAssembler extends NodeAssembler {
      * @returns {String}
      */
     static get prefix() {
-        return DEFAULT_PREFIX
+        return DEFAULT_NAMESPACE_PREFIX
     }
 
     /**
@@ -224,11 +224,8 @@ if(/safari/i.test(window.navigator.userAgent)) {
     const proto = AttrAssembler.prototype
     const setInstance = proto.setInstance
     AttrAssembler.__instances__ = []
-    Object.defineProperty(proto, 'setInstance', {
-        configurable : true,
-        value : function(target) {
-            setInstance.call(this, target)
-            AttrAssembler.__instances__.push(this)
-        }
-    })
+    proto.setInstance = function(target) {
+        setInstance.call(this, target)
+        AttrAssembler.__instances__.push(this)
+    }
 }
diff --git a/lib/const.js b/lib/const.js
@@ -2,7 +2,7 @@ export const TYPE_FUNCTION = 'function'
 export const TYPE_STRING = 'string'
 export const TYPE_UNDEFINED = 'undefined'
 export const DEFAULT_NAMESPACE_URI = ''
-export const DEFAULT_PREFIX = ''
+export const DEFAULT_NAMESPACE_PREFIX = ''
 export const INSTANCE_PROPERTY_NAME = '__instance__'
 export const NAMESPACE_SEPARATOR = ':'
 export const NO_PARENT_INDEX = -1
diff --git a/lib/element.js b/lib/element.js
@@ -1,7 +1,7 @@
 import {
     TYPE_STRING,
     TYPE_FUNCTION,
-    DEFAULT_PREFIX,
+    DEFAULT_NAMESPACE_PREFIX,
     DEFAULT_NAMESPACE_URI,
     NAMESPACE_SEPARATOR,
     NO_PARENT_INDEX
@@ -566,7 +566,7 @@ export class ElementAssembler extends ParentNodeAssembler {
      * @returns {String}
      */
     static get prefix() {
-        return DEFAULT_PREFIX
+        return DEFAULT_NAMESPACE_PREFIX
     }
 
     /**