Multi-instance, limit number, and add tests, warn on failed auth in region #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allenluce
changed the title
You can now supply multiple instances on the command line and it'll actually work. It'll now output a table with instance type in it as well. The -n flag limits the number of line items to a specific count. A testing framework is added. The main module is modified a bit to support being run in test.
This does more promisification of the call chain in order to keep things consistent (i.e. no errors being spit to console from within the promise chain: the final reject is responsible for that). I've noticed intermittent problems with certain regions refusing auth. This adds error handling to report when that happens but will continue through other regions. This also makes some things local instead of global. Using this with lodash's map function streamlines things. It also makes the individual functions callable as a library (in the future). I've removed use of command.action() because the script doesn't actually define commands. Using command.args after parsing is more straightforward. Various minor refactors and validations are done.
allenluce
force-pushed
the
add-some-stuff
branch
from
048af97
to
0053881
Compare
|
@arithmetric got time to review? |
|
@arithmetric I've some other changes to put up when this one gets merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple instances be now be given on the command line. The resulting output table contains the instance type as well.
If a particular region refuses auth the process continues (instead of bombing out).
I've added
-nto limit the number of output items.I've also added a few tests using Mocha and modified the main module to support them.
There's also more promisification done. As well as local'ing some vars and doing other refactors. This tests clean under node versions 6 through 12.