Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix - From line is not showing up on mobile devices #108

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Bugfix - From line is not showing up on mobile devices #108

wants to merge 1 commit into from

Conversation

vagifzeynalov
Copy link

No description provided.

@arithmetric
Copy link
Owner

Thanks for this contribution @vagifzeynalov. I agree that it is better to have quotes around the name part of the From header.

However I think this PR needs additional changes to handle quotes that may be included in the original message:

  • First, many email senders will include quotes around the from name. These quotes around the name should likely be removed so that there are not two sets of quotes in from name in the forwarded message.
  • Second, there may be cases where there are quotes as part of the from name itself. These quotes should be preserved in the forwarded version.

@vagifzeynalov
Copy link
Author

Hi @arithmetric,

Thanks for your response.
Please feel free to close this PR or change it by yourself.
Unfortunately I can't make any changes anymore. :)

Regards,
Vagif

@garychapman
Copy link

garychapman commented Aug 22, 2021

This is quite an important one - we've been seeing emails to Yahoo/Ymail addresses sporadically bouncing for several months now, and it seems to happen when the (unquoted) Display Name is an email address whose domain doesn't match the address in angle brackets. We've started putting quotes around Display Name, all our our emails seem to be arriving.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants