Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(checklist): implemented the checklist #219

Merged
merged 4 commits into from
Nov 3, 2023

Conversation

logickoder
Copy link
Contributor

closes #127

Screen_recording_20231030_120038.mp4

@logickoder
Copy link
Contributor Author

@aritra-tech please review

@aritra-tech
Copy link
Owner

So some changes

  • Right now you are using Show Checklist to show the checkboxes, but we need to remove it and place it in the bottom sheet along with Drawing. I hope you got it.
  • On clicking on the Show Checklist it opens up a bottom sheet where are can add our checkboxes but I want to show the checkboxes along with the notes, check Google Keep Notes once you will be very clear what I wanted.

@logickoder
Copy link
Contributor Author

@aritra-tech please review

Screen_recording_20231031_082817.mp4

@aritra-tech
Copy link
Owner

WhatsApp.Video.2023-11-01.at.11.15.45_f2eb3f7b.mp4

After saving a note with todos when I try to edit that note and delete one of the todos that I've written and update the note when I again go to that note the todo that I have deleted is still there.
Sometimes the card works abnormally if I click on some other card it opens to some other card.
Can you please look into it

…todo_list

# Conflicts:
#	.idea/deploymentTargetDropDown.xml
#	app/src/main/java/com/aritra/notify/components/appbar/AddEditBottomBar.kt
#	app/src/main/java/com/aritra/notify/data/db/NoteDatabase.kt
#	app/src/main/java/com/aritra/notify/ui/screens/notes/addEditScreen/AddEditScreen.kt
#	app/src/main/java/com/aritra/notify/ui/screens/notes/addEditScreen/AddEditViewModel.kt
@logickoder
Copy link
Contributor Author

@aritra-tech please review

Copy link
Owner

@aritra-tech aritra-tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✔

@aritra-tech aritra-tech merged commit ddfb57b into aritra-tech:develop Nov 3, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants