Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Implemented shortcuts #463

Merged
merged 3 commits into from
Jun 14, 2024
Merged

Conversation

tuuhin
Copy link
Contributor

@tuuhin tuuhin commented Jun 11, 2024

Link to the issue #446

Description

Shortcuts help in quickly access parts of an app
This is really helpful in notes app as user can directly move to create note or other contents without the normal workflow before reaching the required destinations

Added two shortcuts

  • One to create note
  • Open the trash bin (this doesn't seems required one )

Please let me know if you want any changes.

Shortcuts help in quickly access parts of the app
Added shortcuts to create a note and open trash.
Added deeplinks to the navigation graph.
NavDeepLinks provides the uri pattern and the uri
AppShortcuts contains all the shortcuts related configurations.
Icons used are the same icon with a surface tint
Linting errors in the previous commit are corrected
Some files have some linting issues those got auto corrected too.
@aritra-tech
Copy link
Owner

For now please remove the shortcut to open trash bin
It's of no use.
@tuuhin

@tuuhin
Copy link
Contributor Author

tuuhin commented Jun 12, 2024

Yeah I just wanted to check if the deep links are working...
Oke I will remove it tomorrow
So for the meantime only shortcut will be create a note ?

@aritra-tech
Copy link
Owner

Yeah I just wanted to check if the deep links are working... Oke I will remove it tomorrow So for the meantime only shortcut will be create a note ?

yeah just for creating the note

Removed shortcut to open trash and removed the associated resources with the shortcut.
Copy link
Owner

@aritra-tech aritra-tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@aritra-tech aritra-tech merged commit 203a027 into aritra-tech:develop Jun 14, 2024
1 check passed
@tuuhin tuuhin deleted the add-shortcuts branch June 14, 2024 18:24
@tuuhin
Copy link
Contributor Author

tuuhin commented Jun 14, 2024

Happy to help 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants