Implement Slash Commands #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bscotty
commented
Sep 1, 2022
•
bscotty
commented
- add interaction type in command declarations
- codify args for those that were not specified
- access args properly once codified (via args property in run method)
- update activity to no longer specify brackets
- reply to /dm-me command both where it is used and via dms
- note that slash commands cannot be used in dms, but the same commands as before can be. rather than registering slash commands globally (which includes dms), register them by the guilds that the bot has been added to, both on login and when added to a new guild
- modify the search command as it can no longer support multiple queries in a single message
- modify the search command as it can no longer reply to a slash command message multiple times (e.g., to support apocalypse rail)
- trim descriptions that are long enough to crash discord api
- register slash commands globally only after login
add interaction type in command declarations codify args for those that were not specified access args properly once codified update activity to no longer specify brackets reply to /dm-me command both where it is used and via dms modify the search command as it can no longer support multiple queries in a single message modify the search command as it can no longer reply to a slash command message multiple times (e.g., to support apocalypse rail) trim descriptions that are long enough to crash discord api register slash commands globally only after login
prevent use of slash commands in dms rather than registering slash commands globally (which includes dms), register them by the guilds that the bot has been added to, both on login and when added to a new guild commands are still registered to the bot as normal message-based commands and can be called safely in DMs so long as the /dm-me command is run in a server channel first reset guildOnly properties to their original values add unique handling for search since it is the only command that doesn't work the same way when called from a slash command and via a message
registering application commands can be rate limited on startup for cached guilds without waiting for the previous call to finish
this avoids requiring the application.commands scope (and therefore updating all permissions of the main uncle bot instance), while also only requiring a single request on launch.
bscotty
force-pushed
the
feature/slash-commands
branch
from
3bb3ca3
to
27c9c7c
Compare
|
here we go 🤞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.