Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Further modifications for FSR producer/associator #39

Merged
merged 4 commits into from
Oct 5, 2019
Merged

Further modifications for FSR producer/associator #39

merged 4 commits into from
Oct 5, 2019

Conversation

peruzzim
Copy link

@peruzzim peruzzim commented Oct 5, 2019

  • Logic changed here:

    cmssw/MuonAnalysis/MuonAssociators/plugins/MuonFSRProducer.cc

    Line 137 in 9d2def0

    if (othermuon->pt() < ptCut or abs(othermuon->eta() > etaCut)) continue;

    that seems the same parenthesis bug on the eta condition
  • Factorization of FSR producer and associator
  • Apply code-format (now mandatory for all PR)
  • Adaptation of nanoAOD python (in a separate commit so you can remove it for the upstream PR)

@arizzi arizzi merged commit 1beb16f into arizzi:nanoAOD-FSR-11_0_0_pre9_withNanoCode Oct 5, 2019
arizzi added a commit that referenced this pull request Oct 5, 2019
@arizzi
Merge pull request #40 from peruzzim/FSRphotons_110X_arizzi_noNano
46f1bfa 
As #39 without NANOAOD code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@peruzzim @arizzi