Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support loading of symbols for debug #9

Closed
Rui1973Martins opened this issue Jul 28, 2015 · 6 comments
Closed

Support loading of symbols for debug #9

Rui1973Martins opened this issue Jul 28, 2015 · 6 comments

Comments

@Rui1973Martins
Copy link

It would be very useful to be able to define a text file with a list of symbols, so that debugger memory locations for CALL, JP, JR, ... and memory (variables) could be replaced to aid debugging.

Sample listing of symbols
image

Then if symbols are loaded, we would get:

CALL BALLB
JR NZ, KBEND
JP EXIT

instead of:

CALL 25011
JR NZ, 24827
JP 24834

It would also be very nice to show labels in monitor window, column "address", next to it's value, using existing symbol definitions. It could be used to document ROM entry points too.

@Rui1973Martins
Copy link
Author

You already seem to support symbol replacement, related with ROM or BASIC addresses.

FRAMES for example.
image

So it's just a matter of providing a file load mechanism to merge a few more definitions.

@ArjunNair
Copy link
Owner

That's a good idea!

@ArjunNair
Copy link
Owner

This feature has now been added.

@sky-ruimartins
Copy link

Cool
I'll try it, as soon as possible.

@sky-ruimartins
Copy link

I just took a quick look at the code, loadSymbolsToolStripMenuItem_Click, and it seems this will not work very well for 128K machines, or any machine that uses memory banks.
But it can depend a lot on how the labels are defined.

I would probably support memory locations larger than 65535, by including some reference to the memory bank, and the relative memory position.

The parsing also seems limited to regular ints (base 10), without support for Hex numbers for example.

@sky-ruimartins
Copy link

I would also suggest that you refactor the loading/parsing of the file, into a specific re-usable function, so that it can be triggered from somewhere else, like for example, by searching if the symbol file exists with the same name but different extension, than the loaded file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants