Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change to logging #169

Merged
merged 4 commits into from Feb 22, 2024
Merged

change to logging #169

merged 4 commits into from Feb 22, 2024

Conversation

arjunsavel
Copy link
Owner

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@arjunsavel arjunsavel mentioned this pull request Feb 22, 2024
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (0d8d3b5) 74.58% compared to head (612260d) 76.23%.
Report is 9 commits behind head on main.

Files Patch % Lines
src/simmer/analyze_image.py 10.53% 17 Missing ⚠️
src/simmer/check_logsheet.py 71.43% 4 Missing ⚠️
src/simmer/image.py 50.00% 4 Missing ⚠️
src/simmer/registration.py 50.00% 2 Missing ⚠️
src/simmer/plotting.py 66.67% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #169      +/-   ##
==========================================
+ Coverage   74.58%   76.23%   +1.65%     
==========================================
  Files          23       25       +2     
  Lines        1900     2301     +401     
==========================================
+ Hits         1417     1754     +337     
- Misses        483      547      +64     
Flag Coverage Δ
unittests 76.23% <49.09%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arjunsavel arjunsavel merged commit 313a025 into main Feb 22, 2024
5 of 9 checks passed
@arjunsavel arjunsavel deleted the logging branch February 22, 2024 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant