Cleanup flag situtation in Variable

ark-lang · Mar 14, 2016 · d2e6c92 · d2e6c92
1 parent 9045cd6
commit d2e6c92
Show file tree

Hide file tree

Showing 7 changed files with 9 additions and 15 deletions.
diff --git a/src/ast/ast.go b/src/ast/ast.go
@@ -136,13 +136,11 @@ type Variable struct {
 	Name         string
 	Mutable      bool
 	Attrs        parser.AttrGroup
-	FromStruct   bool
 	ParentStruct StructType
 	ParentModule *Module
-	IsParameter  bool
-	IsArgument   bool
 
-	IsReceiver bool // TODO separate this out so it isn't as messy
+	// Is the variable not from an variable decl
+	IsImplicit bool
 }
 
 func (v Variable) String() string {

diff --git a/src/ast/constructor.go b/src/ast/constructor.go
@@ -434,7 +434,7 @@ func (c *Constructor) constructVarDeclNode(v *parser.VarDeclNode) *VariableDecl
 		Attrs:        v.Attrs(),
 		Mutable:      v.Mutable.Value != "",
 		ParentModule: c.module,
-		IsReceiver:   v.IsReceiver,
+		IsImplicit:   v.IsImplicit,
 	}
 
 	if v.Type != nil {
@@ -872,8 +872,8 @@ func (c *Constructor) constructFunctionNode(v *parser.FunctionNode) *Function {
 
 	if v.Header.Receiver != nil {
 		function.Receiver = c.constructVarDeclNode(v.Header.Receiver)
-		if !function.Receiver.Variable.IsReceiver {
-			panic("INTERNAL ERROR: Reciever variable was not marked a reciever")
+		if !function.Receiver.Variable.IsImplicit {
+			panic("INTERNAL ERROR: Reciever variable was not marked implicit")
 		}
 
 		// Propagate generic parameters from reciever to method
@@ -900,7 +900,7 @@ func (c *Constructor) constructFunctionNode(v *parser.FunctionNode) *Function {
 	for _, arg := range v.Header.Arguments { // TODO rename v.Header.Arguments to v.Header.Parameters
 		arguments = append(arguments, arg)
 		decl := c.constructVarDeclNode(arg)
-		decl.Variable.IsParameter = true
+		decl.Variable.IsImplicit = true
 		function.Parameters = append(function.Parameters, decl)
 		function.Type.Parameters = append(function.Type.Parameters, decl.Variable.Type)
 	}

diff --git a/src/ast/mangle.go b/src/ast/mangle.go
@@ -173,9 +173,6 @@ func (v Variable) MangledName(typ MangleType) string {
 	switch typ {
 	case MANGLE_ARK_UNSTABLE:
 		result := fmt.Sprintf("_V%d%s", len(v.Name), v.Name)
-		if v.FromStruct {
-			result = v.ParentModule.MangledName(typ) + result
-		}
 		return result
 	default:
 		panic("")

diff --git a/src/ast/visitor.go b/src/ast/visitor.go
@@ -183,7 +183,6 @@ func (v *ASTVisitor) VisitChildren(n Node) {
 		n.Subscript = v.VisitExpr(n.Subscript)
 
 	case *SizeofExpr:
-		// TODO: Maybe visit sizeofExpr.Type at some point?
 		n.Expr = v.VisitExpr(n.Expr)
 
 	case *ArrayLenExpr:

diff --git a/src/parser/parse_tree.go b/src/parser/parse_tree.go
@@ -218,7 +218,7 @@ type VarDeclNode struct {
 	Value   ParseNode
 	Mutable LocatedString
 
-	IsReceiver           bool
+	IsImplicit           bool
 	ReceiverGenericSigil *GenericSigilNode
 }
 

diff --git a/src/parser/parser.go b/src/parser/parser.go
@@ -727,7 +727,7 @@ func (v *parser) parseVarDeclBody(isReceiver bool) *VarDeclNode {
 	res := &VarDeclNode{
 		Name:       NewLocatedString(name),
 		Type:       varType,
-		IsReceiver: isReceiver,
+		IsImplicit: isReceiver,
 	}
 	start := name.Where.Start()
 	if mutable != nil {

diff --git a/src/semantic/unused.go b/src/semantic/unused.go
@@ -65,7 +65,7 @@ func (v *UnusedCheck) AnalyzeUsage(s *SemanticAnalyzer) {
 		decl := v.encounteredDecl[idx]
 		switch it := it.(type) {
 		case *ast.Variable:
-			if !it.IsParameter && !it.IsReceiver && !it.FromStruct && v.uses[it] == 0 {
+			if !it.IsImplicit && v.uses[it] == 0 {
 				s.Warn(decl, "Unused variable `%s`", it.Name)
 			}