Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unresolved references in Telegram Bot API 7.2 update #20

Open
kravetsone opened this issue Mar 31, 2024 · 8 comments
Open

Unresolved references in Telegram Bot API 7.2 update #20

kravetsone opened this issue Mar 31, 2024 · 8 comments

Comments

@kravetsone
Copy link

The new Telegram Bot API 7.2 objects do not exist in the schema, but other objects reference them

image
image

@ENCRYPTEDFOREVER
Copy link

Looks like this is caused by absence of description for these objects...

@kravetsone
Copy link
Author

Looks like this is caused by absence of description for these objects...

Yes! We have already discussed this with the author. Would you like to do a PR?)

@ENCRYPTEDFOREVER
Copy link

Yes! We have already discussed this with the author.

Any suggestions on fix?

@kravetsone
Copy link
Author

Yes! We have already discussed this with the author.

Any suggestions on fix?

I'm not familiar with Rust much, so I didn't do it myself. The author suggests leaving an empty string in the absence of a description

Unfortunately, the documentation is poorly done(

I tried to write in @bottalk chats / bot support, but I got no result...

@ENCRYPTEDFOREVER
Copy link

ENCRYPTEDFOREVER commented Apr 3, 2024

I don't think I have time now to do a proper PR but for a dirty fix you can go to src/extractor.rs, line 66 and prepend

else if select_any.peek().matches(&table) {
    State::GetObjectFields {
        name: elem,
        description: RawDescription::default(),
    }
}

before the 'else' block.

kravetsone added a commit to gramiojs/types that referenced this issue Apr 4, 2024
@ark0f
Copy link
Owner

ark0f commented Jun 23, 2024

It looks like issue was fixed after they added descriptions to entities like BusinessLocation, BusinessIntro, etc 😅

@nitreojs
Copy link

can confirm, it has been fixed since then. the issue might be closed

@ENCRYPTEDFOREVER
Copy link

The issue might be closed

It might reoccur in the future, it's better to implement such case handling...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants