Fix Hackenproof rewards entry (#148)

Co-authored-by: arkadiyt <>
arkadiyt · Aug 6, 2023 · fc5e7f1 · fc5e7f1
1 parent fa2672f
commit fc5e7f1
Show file tree

Hide file tree

Showing 4 changed files with 462 additions and 805 deletions.
diff --git a/.dockerignore b/.dockerignore
@@ -1,3 +1,4 @@
 bundle/
 coverage/
 spec/
+vendor/
diff --git a/lib/bounty-targets/hackenproof.rb b/lib/bounty-targets/hackenproof.rb
@@ -42,7 +42,8 @@ def directory_index
             id: link.attributes['href'].value,
             name: link.inner_text.strip,
             url: URI.join('https://hackenproof.com', link.attributes['href'].value).to_s,
-            archived: node.classes.include?('archived-program')
+            archived: node.classes.include?('archived-program'),
+            triaged_by_hackenproof: !node.css('.triaged-by').empty?
           }
         end)
 
@@ -82,10 +83,10 @@ def scopes_to_hashes(tag)
         scopes_target = row.css('.scopes-target-inner')
         {
           target: scopes_target.css('h5').remove.inner_text.strip,
-          type: row.css('td')[1].inner_text.strip,
+          type: row.css('.type-cell').inner_text.strip,
           instruction: scopes_target.inner_text.strip,
-          severity: row.css('td')[2].inner_text.strip,
-          reward: row.css('td')[3]&.inner_text&.strip
+          severity: row.css('.severity-cell').inner_text.strip,
+          reward: row.css('.reward-cell').inner_text.strip
         }
       end
     end

diff --git a/spec/bounty-targets/hackenproof_spec.rb b/spec/bounty-targets/hackenproof_spec.rb
@@ -15,27 +15,27 @@
 
     expect(client.directory_index).to eq(
       [{id: '/hacken/hackenproof', name: 'HackenProof', url: 'https://hackenproof.com/hacken/hackenproof',
-        archived: false},
+        archived: false, triaged_by_hackenproof: true},
        {id: '/kuna/kuna-crypto-exchange', name: 'Kuna Crypto Exchange',
-        url: 'https://hackenproof.com/kuna/kuna-crypto-exchange', archived: false},
+        url: 'https://hackenproof.com/kuna/kuna-crypto-exchange', archived: false, triaged_by_hackenproof: true},
        {id: '/vechain/vechainthor', name: 'VeChainThor', url: 'https://hackenproof.com/vechain/vechainthor',
-        archived: false},
+        archived: false, triaged_by_hackenproof: true},
        {id: '/vechain/vechainthor-wallet', name: 'VeChainThor Wallet',
-        url: 'https://hackenproof.com/vechain/vechainthor-wallet', archived: false},
-       {id: '/gate-dot-io/gate-dot-io-exchange', name: 'Gate.io Exchange',
-        url: 'https://hackenproof.com/gate-dot-io/gate-dot-io-exchange', archived: false},
+        url: 'https://hackenproof.com/vechain/vechainthor-wallet', archived: false, triaged_by_hackenproof: true},
+       {id: '/gate-dot-io/gate-dot-io-exchange', name: 'Gate.io Exchange', url:
+        'https://hackenproof.com/gate-dot-io/gate-dot-io-exchange', archived: false, triaged_by_hackenproof: false},
        {id: '/coingecko/coingecko', name: 'CoinGecko', url: 'https://hackenproof.com/coingecko/coingecko',
-        archived: false},
+        archived: false, triaged_by_hackenproof: true},
        {id: '/p2pb2b/p2pb2b', name: 'P2PB2B', url: 'https://hackenproof.com/p2pb2b/p2pb2b',
-        archived: false},
+        archived: false, triaged_by_hackenproof: false},
        {id: '/coinsbit/coinsbit', name: 'Coinsbit', url: 'https://hackenproof.com/coinsbit/coinsbit',
-        archived: false},
+        archived: false, triaged_by_hackenproof: false},
        {id: '/hotbit/hotbit', name: 'Hotbit', url: 'https://hackenproof.com/hotbit/hotbit',
-        archived: false},
+        archived: false, triaged_by_hackenproof: true},
        {id: '/whitebit/whitebit', name: 'WhiteBIT', url: 'https://hackenproof.com/whitebit/whitebit',
-        archived: false},
+        archived: false, triaged_by_hackenproof: false},
        {id: '/vechain/vechainthor-vip191', name: 'VeChainThor VIP191',
-        url: 'https://hackenproof.com/vechain/vechainthor-vip191', archived: true}]
+        url: 'https://hackenproof.com/vechain/vechainthor-vip191', archived: true, triaged_by_hackenproof: false}]
     )
   end
 
@@ -49,18 +49,18 @@
           {
             instruction: 'HackenProof main site',
             reward: 'Bounty',
-            type: 'WEB',
+            type: 'Web',
             target: 'hackenproof.com',
             severity: 'Critical'
           }
         ],
         out_of_scope: [
           {
             target: 'blog.hackenproof.com',
-            type: 'WEB',
+            type: 'Web',
             instruction: 'Our Blog',
             severity: 'None',
-            reward: '--'
+            reward: ''
           }
         ]
       }