Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there a reason that this agent doesn't allow collecting stacktraces? #176

Open
kvas-damian opened this issue Oct 11, 2023 · 2 comments · May be fixed by #177
Open

Is there a reason that this agent doesn't allow collecting stacktraces? #176

kvas-damian opened this issue Oct 11, 2023 · 2 comments · May be fixed by #177

Comments

@kvas-damian
Copy link

First of all, thanks for your work on this repo. We successfully migrated from https://github.com/philkra/elastic-apm-laravel and we love possibility to register our own collectors (DB transactions, Redis, HTTP requests and others).

The only feature that we're missing from the previous APM integration is lack of stacktraces. In APM stacktraces looks as on screenshot and allows us to easily trace the source of the Span
Zrzut ekranu 2023-10-11 o 10 00 24

I found a method that allows us to set stacktraces on Span in APM agent, so it should be fairly easy to pass it through Agent

Summarizing, the question is: Is it intended that this Agent doesn't allow to record spans with stacktraces?

@arkaitzgarro
Copy link
Owner

Hey @kvas-damian ,

No specific reason we didn't implement stacktraces, we were focused on implementing other features I guess. I could take a look in a few weeks, but feel free to open a PR if you think you can make it work :)

@kvas-damian kvas-damian linked a pull request Oct 11, 2023 that will close this issue
@kvas-damian
Copy link
Author

@arkaitzgarro please take a look on #177

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants