Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stacktrace to span #177

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

kvas-damian
Copy link

@kvas-damian kvas-damian commented Oct 11, 2023

Fixes #176

Copy link
Owner

@arkaitzgarro arkaitzgarro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, I will take a look as soon as possible and see if we can add some tests.

README.md Outdated Show resolved Hide resolved
src/Helpers/StacktraceExtractor.php Outdated Show resolved Hide resolved
@arkaitzgarro
Copy link
Owner

Hey @kvas-damian,

I managed to make it work locally, and it shows the stacktraces on span level.

Screenshot 2023-10-22 at 11 20 39

Could you fix the following:

  • Move renderSource config into span block, since the code expects it to be there. And make it false by default, I'm a bit concern it may blow up some Kibana clusters with a high number of spans. Update the docs.
  • Move getStacktrace to the parent method, to avoid extra loops.

@kvas-damian
Copy link
Author

Thanks for your feedback. I'll try to apply changes today

@arkaitzgarro
Copy link
Owner

Looking good, thanks @kvas-damian !

@kvas-damian
Copy link
Author

Unfortunately, I wasn't able to find a way to cover StacktraceExtractor... It depend on base_path() from Laravel, which cannot be run without bootstrap/app.php :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is there a reason that this agent doesn't allow collecting stacktraces?
2 participants