-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(collectors): add command and scheduled tasks collectors #76
feat(collectors): add command and scheduled tasks collectors #76
Conversation
fc1d28b
to
6d3cd66
Compare
|
I'd expect that. I'll see if I can reproduce it and adjust the "fake status code" from 200 to something else. If I remember correctly, in Symfony, the command could return a status code in the handle method and that was it. However what I meant was when an exception is thrown and not handled in the command, then listener doesn't seem to fire, but the app terminate middleware executes send on the agent. In phikra there was this naughty thing that adding errors. |
Ok, I've added the status code check. I've also noticed I've been wrong about |
…ion methods to parent from child classes to avoid duplication
test(unit.collectors): command collector test
7f07546
to
e41e343
Compare
chore(ci): appease cs checker
Co-authored-by: Arkaitz Garro <arkaitz.garro@gmail.com>
ab26a15
to
5de527c
Compare
Adds collectors for cli commands and scheduled tasks.
Closes #75
todo:
1: not sure what to do with tests for the scheduler the classes are missing in L5.5 + some issues with starting test in command collector