Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Equipment with a profession set bonus marked unusable [BUG] #1507

Closed
the-chuppa opened this issue Aug 22, 2021 · 4 comments
Closed

Equipment with a profession set bonus marked unusable [BUG] #1507

the-chuppa opened this issue Aug 22, 2021 · 4 comments
Labels
bug its a bug

Comments

@the-chuppa
Copy link

version: v30955.11 (Alpha) (this is not a new issue)
client: BCC

Equipment, which has a set bonus requiring a profession such as Heavy Clefthoof Leggings, is tinted unsuable when the player does not have the required profession, even though the item itself is perfectly usable.

image

@arkayenro
Copy link
Owner

not an easy fix as its a perfect match for not actually being able to use it

@arkayenro arkayenro added the bug its a bug label Aug 22, 2021
@the-chuppa
Copy link
Author

I'm no addon developer but from looking at your code it seem you're parsing the tooltip line by line and looking for a red line. How about you stop parsing the tooltip when you hit a set bonus line?

But now I thought about a similar issue - the profession-only enchants/gems. If I were to drop enchanting, my enchanted rings would say "Requires Enchanting...", but the ring would still be usable, only the enchant would not work.

@arkayenro
Copy link
Owner

i dont just scan straight down though. i cater for recipes/patterns where the object created is also in the tooltip, and also potentially has level, class, skill, requirements you dont meet - but can create - so i scan down also looking for an empty line, if i hit one i go to the bottom and scan up - thats meant to get around the item in a recipe or pattern.

that has worked for everything so far - except set bonuses you dont meet

@arkayenro
Copy link
Owner

this should be fixed in 3.10.00 alpha 11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug its a bug
Projects
None yet
Development

No branches or pull requests

2 participants