Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"outfit()" rule only works for sets created with Blizzard Equipment Manager if no other equipment management addons are present. #1605

Closed
viliger2 opened this issue Sep 29, 2022 · 3 comments

Comments

@viliger2
Copy link

viliger2 commented Sep 29, 2022

What version number you are using?
3.09.68 & 3.10.00-alpha-6

What game client are you playing? Retail, Burning Crusade, Classic / Live, PTR, Beta
Wrath of the Lich King Classic

What language is the game client set to?
English

Describe the bug
"outfit()" rule only works for sets created with Blizzard Equipment Manager if no other equipment management addons are present.

To Reproduce
I've created a set in Blizzard Equipment Manager to use in a macro, created a rule for it in rule book, assigned it to a bar and it doesn't work if I have ItemRack enabled. If I disable it rules start to work.

Screenshots

Additional context
I've checked the code of the function ArkInventoryRules.System.boolean_outfit( ... ) in ArkInventoryRules.lua and it returns the first possible result, depending on which addon is loaded

if IsAddOnLoaded( "Outfitter" ) and Outfitter:IsInitialized( ) then
	return ArkInventoryRules.System.boolean_outfit_outfitter( ... )
end

if IsAddOnLoaded( "ItemRack" ) then
	return ArkInventoryRules.System.boolean_outfit_itemrack( ... )
end

if IsAddOnLoaded( "GearQuipper" ) or IsAddOnLoaded( "GearQuipper-TBC" ) then
	return ArkInventoryRules.System.boolean_outfit_gearquipper( ... )
end

if C_EquipmentSet and C_EquipmentSet.CanUseEquipmentSets( ) then
	return ArkInventoryRules.System.boolean_outfit_blizzard( ... )
end

return false

If we are to slightly rewrite it to use separate value and then return it then it would work with multiple outfit addons. I know it is a niche use and I understand if the fix doesn't make it, but I would appreciate it.

@arkayenro
Copy link
Owner

arkayenro commented Sep 29, 2022

yeah, its easy to make them all work but i couldnt find a reason for someone to use more than one outfit mod so i didnt at the time.

it wont hurt to make it cascade through them all though

@arkayenro arkayenro changed the title [BUG] "outfit()" rule only works for sets created with Blizzard Equipment Manager if no other equipment management addons are present. "outfit()" rule only works for sets created with Blizzard Equipment Manager if no other equipment management addons are present. Sep 29, 2022
@arkayenro
Copy link
Owner

duplicate of #1578 (sort of)

@arkayenro
Copy link
Owner

added to 3.10.00 alpha 7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants