c2a-core hal crates: require c2a-core v4 #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rebase |
sksat
force-pushed
the
feature/specify-major-version-in-hal-crates
branch
from
226d64e
to
5e981f2
Compare
meltingrabbit
approved these changes
Dec 25, 2023
|
rebase |
sksat
force-pushed
the
feature/specify-major-version-in-hal-crates
branch
from
5e981f2
to
67b94d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
#133 と同様に，
halの各 crate で要求するc2a-core（crate）のバージョン指定を major version のみにする詳細
特定の c2a-core minor, patch version によらずに c2a-core hal の crate を使えるようになる
検証結果
CI が通ればよし
影響範囲
これにより，c2a-core hal crate で bindgen 経由で用いている C2A の関数群は major version で維持しなければならないインターフェースとなる（semver のバージョン判断をする API として扱うことになる）
補足
beta release は major version のみの指定では扱えないので，v4.0.0 のリリース以降