Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix examples/subobc pytest testcase dir #286

Merged
merged 2 commits into from
Jan 11, 2024
Merged

Conversation

sksat
Copy link
Member

@sksat sksat commented Jan 11, 2024

概要

examples/subobc の pytest のテストケースのディレクトリがおかしかったので修正

Issue / PR

詳細

#273 でなぜか v4 の時に消した src_user/test/test が復活してしまっているので,戻した

検証結果

test へのリンクや,検証結果へのリンク

影響範囲

examples/subobc の pytest

補足

テストケースのディレクトリを分けたかったとしても,意味のある命名をすべき(ここで中途半端でもアイデアが無いなら不要な混乱によるデメリットの方が大きいため分けるべきではない)

@sksat sksat added invalid This doesn't seem right priority::high priorityg high tools labels Jan 11, 2024
@sksat sksat self-assigned this Jan 11, 2024
@sksat sksat force-pushed the hotfix/example-subobc-pytest-dir branch from ccc5258 to 10a61cc Compare January 11, 2024 06:10
@meltingrabbit
Copy link
Member

test ファイルが復数になってきたからフォルダ切ったけど,当面 test/ 配下にどんどん追加していく感じで良い?

@sksat
Copy link
Member Author

sksat commented Jan 11, 2024

@meltingrabbit 当面は test_*.pysrc_user/test 以下に配置,で問題無いと思うし,問題がある規模になってきたら 文脈ごとに ディレクトリを区切るべき.test/test は何もわからない.

@meltingrabbit
Copy link
Member

OK

@sksat
Copy link
Member Author

sksat commented Jan 11, 2024

rebase

@sksat sksat force-pushed the hotfix/example-subobc-pytest-dir branch from 8b42db3 to 0bdb835 Compare January 11, 2024 08:11
@sksat sksat merged commit 7440d2a into main Jan 11, 2024
37 checks passed
@sksat sksat deleted the hotfix/example-subobc-pytest-dir branch January 11, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right priority::high priorityg high tools
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants