Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

96 nits & question #1342

Closed
practik opened this issue Jan 21, 2022 · 1 comment
Closed

96 nits & question #1342

practik opened this issue Jan 21, 2022 · 1 comment

Comments

@practik
Copy link

practik commented Jan 21, 2022

Nice update! It's so much lighter and airier in here now with 2300 and 4000 cleared out of the way. I made the switch to dFPI a couple of weeks ago (so far so good), but it's nice to have the official version of the JS.

Two minor goofs I noticed:
line 3: year should be 2022
line 1092: pref # should be 6007

Also, just curious: Why did you bring back browser.eme.ui.enabled?
fxbrit pushed a commit to fxbrit/user.js that referenced this issue Jan 22, 2022
close arkenfox#1342
05c1609
@fxbrit
Copy link
Collaborator

fxbrit commented Jan 22, 2022

Also, just curious: Why did you bring back browser.eme.ui.enabled?

87bd868

thanks for reporting the nits, I made a PR. good eyes uh.

Thorin-Oakenpants pushed a commit that referenced this issue Jan 22, 2022
typos #1342 (#1343)
10044fc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@practik @Thorin-Oakenpants @fxbrit