Overriding network.captive-portal-service.enabled leads to crash [1800603, fixed FF111+]

[dartraiden]

Firefox 106.0.5 (x64), Windows 11 (my real PC) / Windows 10 (VM) / Ubuntu 22.04.1 (VM), new profile:

• Create a minimal user.js

/** OTHER ***/
/* 0360: disable Captive Portal detection
 * [1] https://www.eff.org/deeplinks/2017/08/how-captive-portals-interfere-wireless-security-and-privacy ***/
user_pref("captivedetect.canonicalURL", "");
user_pref("network.captive-portal-service.enabled", false); // [FF52+]
/* 0361: disable Network Connectivity checks [FF65+]
 * [1] https://bugzilla.mozilla.org/1460537 ***/
user_pref("network.connectivity-service.enabled", false);

Add overrides:

user_pref("captivedetect.canonicalURL", "http://detectportal.firefox.com/canonical.html");
user_pref("network.captive-portal-service.enabled", true);
user_pref("network.connectivity-service.enabled", true);

Run Firefox. Result - instant crash. Removing user_pref("network.captive-portal-service.enabled", true); override solves the problem. For some reason, Firefox crashes if the network.captive-portal-service.enabled is set to false and then overridden by true

[fxbrit]

I reproduced this in Nightly 108 by applying the full user.js, the above overrides and running the updater script. also reproduced by appending user_pref("network.captive-portal-service.enabled", true); to the end of the user.js.

brand new profile with a user.js as follows is fine:

// try this
user_pref("network.connectivity-service.enabled", false);
user_pref("network.connectivity-service.enabled", true);

---

PSA: if you try this do it in a disposable profile you don't care about.

if Firefox refuses to start run it from the command line with option --ProfileManager, delete the corrupted profile and pick the one you prefer.

[dartraiden]

brand new profile with a user.js as follows is fine

Yes, the bare minimum user.js for this bug is

user_pref("network.captive-portal-service.enabled", false);
user_pref("network.captive-portal-service.enabled", true);

Ticket created: https://bugzilla.mozilla.org/show_bug.cgi?id=1800603

[Thorin-Oakenpants]

if you want it to land under the right owner for attention/triage, the product is Core and the component is Networking

[Thorin-Oakenpants]

FYI: 1800603 just landed

[Thorin-Oakenpants]

closing as fixed in FF111 (reopen if the upstream patch was a failure - no one has verified it yet)

[Thorin-Oakenpants]

verified fixed: https://bugzilla.mozilla.org/show_bug.cgi?id=1800603#c19