Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

browser.xul.error_pages.expert_bad_cert #26

Closed
earthlng opened this issue Feb 22, 2017 · 4 comments
Closed

browser.xul.error_pages.expert_bad_cert #26

earthlng opened this issue Feb 22, 2017 · 4 comments
Assignees

Comments

@earthlng
Copy link
Contributor

write up a pull-request to set this one to true and give props to @crssi

@earthlng
Copy link
Contributor Author

earthlng commented Feb 22, 2017

Pants, can you give @crssi some kind of membership? He helps out a lot.
No write-access, just so everyone knows he's a part of this and to make his name show up when I type an @

@earthlng
Copy link
Contributor Author

earthlng commented Feb 22, 2017

what's the benefit of this enhancement, what does it do exactly? Need more info/discussion before a pull

#10 (comment)

@crssi
Copy link

crssi commented Feb 22, 2017

Guys, I have much to learn. Now I have to find out what "collaborator" means. Until I get shot for that, I guess its fine. lol

Do I need to accept anything?

And since I am new to git, its is really safer read-only mode. :)

@earthlng
Copy link
Contributor Author

earthlng commented Feb 23, 2017

I wanted to title the pref as something like "blabla on Insecure Connection warning pages".
To make sure that's correct, I clicked all insecure links on badssl.com, and turns out it's not 100% correct.
There's one exception with HSTS:

https://subdomain.preloaded-hsts.badssl.com/
This site uses HTTP Strict Transport Security (HSTS) to specify that Firefox may only connect to it securely. As a result, it is not possible to add an exception for this certificate.

In those cases the pref doesn't display the advanced info.

Damn, now I have to incorporate that somehow :(

// 12xx: display Advanced information on Insecure Connection warning pages (thanks @crssi)
   // only works when it's possible to add an exception, fe. doesn't work for HSTS (https://subdomain.preloaded-hsts.badssl.com/)
   // testpage: https://expired.badssl.com/
user_pref("browser.xul.error_pages.expert_bad_cert", true);

Pants, how is that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants