Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow silent execution #1185

Closed
wants to merge 3 commits into from
Closed

Allow silent execution #1185

wants to merge 3 commits into from

Conversation

samsapti
Copy link

@samsapti samsapti commented Jun 5, 2021

I've added a commandline argument -s to allow for silent execution of the script. This is useful if the user wants to automate the process of updating the user.js and cleaning prefs.

@earthlng
Copy link
Contributor

earthlng commented Jun 6, 2021

Hi, thanks for the PR.

I like the idea but I don't think we need getopts + a new variable for 1 parameter.
I also want to keep showing the banner + text and calling the parameter 'silent' isn't really accurate either.

I'll close this and create a new PR and you can let me know what you think

@earthlng earthlng closed this Jun 6, 2021
@samsapti samsapti mentioned this pull request Jun 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants