Minor coding style changes and typo fixes

[likewhoa]

1. Switched to BASH Arithmetic expressions for some if statements that used numbers.
2. Added ${var} as best practice
3. Minor spelling fixes

[arkhebuz]

exit got lost here i guess

[likewhoa]

Just a much better way to print multiple lines, instead of having all those echos :D

[arkhebuz]

Still no exit

[likewhoa]

oh I missed the exit

[arkhebuz]

Hmm, what am I doing here...
Didn't want to merge with master so I created new branch, then cherry-picked your commit from there and tried to fix the above. There's probably better way around somewhere... ...outside my github skills.

Could you explain why using ${var} everywhere is best practice? I know there are situations where they are clearly needed (like arrays).

Thanks for noticing the script and writing the patch, though!

[likewhoa]

@arkhebuz ${var} habit for me really, but allot of people in #bash can agree on making a habit in ${var} and or "${var}"

[arkhebuz]

As far as Bash practices go, I would call quotation marks mandatory if you don't want end up like bumblebe.

About these DNS servers, I checked that with echos like below to be sure.

declare -A dns_serversA=( [google2]=8.8.4.4 [opendns1]=208.67.222.222 [level3]=209.244.0.3 [comodo]=8.26.56.26 [google1]=8.8.8.8 )
dns_servers=(8.8.8.8 8.8.4.4 208.67.222.222 209.244.0.3 8.26.56.26)
echo "\${dns_servers[@]}         ${dns_servers[@]}"
echo "\${dns_servers[@]:1:4}     ${dns_servers[@]:1:4}"
echo "\${dns_servers[google1]}   ${dns_servers[google1]}"
echo ""
echo "\${dns_serversA[@]}         ${dns_serversA[@]}"
echo "\${dns_serversA[@]:1:4}     ${dns_serversA[@]:1:4}"
echo "\${dns_serversA[google1]}   ${dns_serversA[google1]}"

And this gives me:

${dns_servers[@]}         8.8.8.8 8.8.4.4 208.67.222.222 209.244.0.3 8.26.56.26
${dns_servers[@]:1:4}     8.8.4.4 208.67.222.222 209.244.0.3 8.26.56.26
${dns_servers[google1]}   8.8.8.8

${dns_serversA[@]}         208.67.222.222 8.8.4.4 8.8.8.8 8.26.56.26 209.244.0.3
${dns_serversA[@]:1:4}     208.67.222.222 8.8.4.4 8.8.8.8 8.26.56.26
${dns_serversA[google1]}   8.8.8.8

So I need to fix the fix of a patch.

[arkhebuz]

OK, if you have something more to comment here, feel free to do so. I will merge the second branch (based on your modified patch) with master soon, then close this request.

Little long discussion for such small piece of code... 100 sloc in Bash - serious business.