Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: allow std::function for STM32 #105

Closed
wants to merge 1 commit into from

Conversation

shroomist
Copy link

naive poking showed that std::function works for stm32

Screenshot 2020-10-01 at 12 50 08

@arkhipenko
Copy link
Owner

I don't use this, but thanks! Will review and merge.

@GitMoDu
Copy link

GitMoDu commented Dec 18, 2020

Please review Platform identifiers before merging, as discussed here.

@arkhipenko
Copy link
Owner

Please review Platform identifiers before merging, as discussed here.

Why would support for general architecture (if it is indeed supported) be worse than listing endless defines for each variety?

@GitMoDu
Copy link

GitMoDu commented Jan 1, 2021

It's an option that's more useful for libraries that depend more on Arduino core functionality, or not at all.
Since TaskScheduller basically only uses the millis()/micros() from the Arduino API, everything else being plain C++, I'd say I agree with you.
Just wanted to make sure you are aware how touchy the subject actually is, because it's a mess right now on STM32 side with 3, concurrent and incompatible Cores (STM32, Roger's and Steve's)

@arkhipenko
Copy link
Owner

ok.
yield() is empty in stm32 implementation, so I did not include the second update.
merged into 'testing' branch.

@arkhipenko arkhipenko closed this Jan 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants