Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Popup in CK Editor #37

Open
amenk opened this issue Feb 5, 2016 · 13 comments
Open

No Popup in CK Editor #37

amenk opened this issue Feb 5, 2016 · 13 comments

Comments

@amenk
Copy link
Contributor

amenk commented Feb 5, 2016

We are using the commercial EasyRedmine extensions and HTML which seems to be based on CKEditor as well.

When typing @ there is no popup with the user names.

Could this be fixed?

We might be able to sponsor the fixing of this issue.

@amenk
Copy link
Contributor Author

amenk commented Feb 5, 2016

This is actually almost working:

yuku/textcomplete#90

soxhub/jquery-textcomplete@89729d4

@amenk
Copy link
Contributor Author

amenk commented Feb 5, 2016

I changed the invocation to this: https://github.com/arkhitech/redmine_mentions/blob/master/app/views/hooks/redmine_mentions/_edit_mentionable.html.erb#L14

But actually I called this manually because initially it did not work. I guess I would have to call it after the CKEditor initialization

But when I type now something like @fo and press Tab, I end up in @foo o.
Also I get the error

Uncaught TypeError: Cannot read property 'clientTop' of undefinedCKEDITOR.tools.extend.getDocumentPosition @ ckeditor.js:104U @ ckeditor.js:975r @ ckeditor.js:977v.mouseNear @ ckeditor.js:964(anonymous function) @ ckeditor.js:981

@amenk
Copy link
Contributor Author

amenk commented Feb 24, 2016

I was able to fix the "clientTop" error by removing the .overlay() call on the CKEditor

@amenk
Copy link
Contributor Author

amenk commented Feb 24, 2016

my current version - but still problems with completion
https://github.com/arkhitech/redmine_mentions/compare/master...iMi-digital:fix-37-ck-editor?expand=1

@hishammalik
Copy link
Member

will try to plan development over this in 2-3 week's. Doesn't look possible to invest time at this time.

@amenk
Copy link
Contributor Author

amenk commented Feb 25, 2016

@hishammalik that sounds good. Did you have a look at my changes? The patch for redmine_mentions seems to work quite well. With the jquery.textcomplete the problem seems to be that keydowns are not properly catched. Are you planning to fix this in jquery.textcomplete?

@amenk
Copy link
Contributor Author

amenk commented Mar 3, 2016

@hishammalik Sorry to bother you. Can you give me feedback what is the plan? In case we can support you with anything ...

@amenk
Copy link
Contributor Author

amenk commented Apr 1, 2016

@hishammalik Would appreciate a short feedback, what is the plan with this issue - is it about the javascript fixing?

@amenk
Copy link
Contributor Author

amenk commented Apr 15, 2016

I will have a look at it again now ...

@archonwang
Copy link

O. I will tested it later. Thanks. @amenk

@amenk
Copy link
Contributor Author

amenk commented May 19, 2016

I tried to reproduce the issue without redmine, just the CK editor and textcomplete soxhub/jquery-textcomplete@89729d4 - this actually works well .. have to dig further - might be an issue of the redmine specific config

@amenk
Copy link
Contributor Author

amenk commented May 19, 2016

I got it working also in redmine using the latest CK editor and the just mentioned patch. Will you merge it from @soxhub?

amenk added a commit to iMi-digital/redmine_mentions that referenced this issue May 19, 2016
amenk added a commit to iMi-digital/redmine_mentions that referenced this issue May 19, 2016
@amenk
Copy link
Contributor Author

amenk commented May 26, 2016

Current Problem: It is not working with the CKEditor "tabs" Plugin which is used in EasyRedmine - so will try another approach.

amenk added a commit to iMi-digital/redmine_mentions that referenced this issue May 26, 2016
- Contains textcomplete from my pull request yuku/textcomplete#253
 - Basically compatible with the tabs plugin and other quirks
- Also deactivate the overlay which destroys the CK Editor
@amenk amenk mentioned this issue May 26, 2016
amenk added a commit to iMi-digital/redmine_mentions that referenced this issue May 26, 2016
- Contains textcomplete from my pull request yuku/textcomplete#253
 - Basically compatible with the tabs plugin and other quirks
- Also deactivate the overlay which destroys the CK Editor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants