Merge pull request #576 from Chen-Xi-g/fix-issue

Fixed the issue of 'HorizontalPager' slow scrolling and 'onPageSelected' not being called.
arkivanov · Dec 17, 2023 · 5d54157 · 5d54157
2 parents 0801120 + a36e5a1
commit 5d54157
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/...src/commonMain/kotlin/com/arkivanov/decompose/extensions/compose/jetbrains/pages/Pages.kt b/...src/commonMain/kotlin/com/arkivanov/decompose/extensions/compose/jetbrains/pages/Pages.kt
@@ -81,7 +81,7 @@ fun <C : Any, T : Any> Pages(
         }
     }
 
-    DisposableEffect(state.currentPage) {
+    DisposableEffect(state.currentPage, state.targetPage) {
         if (state.currentPage == state.targetPage) {
             onPageSelected(state.currentPage)
         }

diff --git a/...e-jetpack/src/main/java/com/arkivanov/decompose/extensions/compose/jetpack/pages/Pages.kt b/...e-jetpack/src/main/java/com/arkivanov/decompose/extensions/compose/jetpack/pages/Pages.kt
@@ -81,7 +81,7 @@ fun <C : Any, T : Any> Pages(
         }
     }
 
-    DisposableEffect(state.currentPage) {
+    DisposableEffect(state.currentPage, state.targetPage) {
         if (state.currentPage == state.targetPage) {
             onPageSelected(state.currentPage)
         }