Shellcheck #1139
Closed
Shellcheck #1139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exit codes should be >= 0, negative is not well defined
`${NORMAL}` needs `echo -e`
assume variables are assigned (SC2154)
klightspeed
reviewed
Aug 18, 2020
| @@ -1748,6 +1751,8 @@ isUpdateCancelRequested(){ | |||
| xargs -0 grep -F -e "${chatCommandRestartCancel}" | | |||
| sed 's@^[[]\(....\)\.\(..\)\.\(..\)-\(..\)\.\(..\)\.\(..\):.*@\1-\2-\3 \4:\5:\6 UTC@' | | |||
| head -n1)" | |||
| # canceltime is a command, not a string | |||
| # shellcheck disable=SC2157 | |||
| if [ -n canceltime ]; then | |||
There was a problem hiding this comment.
I think canceltime should be "${canceltime}"
|
I like it. |
|
On another note: can I persuade netinst.sh or the updater to the branch on my fork, so I can run some tests? I've noticed the variables are there, but I have not figured out how to parameterize those. |
|
I have added a |
|
I have now implemented the idea in this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an effort to make the
arkmanagermore robust, I've let it lint by shellcheck, got rid of all "errors" and implemented some of their hints in different warnings.On top of that, I've set up a Github action that runs shellcheck on every push. It'll be nagging a lot, since I've configured the "error" threshold as "warning" (see f5312ee), but I'll go ahead and change more things.