Skip to content
This repository has been archived by the owner on Nov 16, 2021. It is now read-only.

Trigger onchanges when attributes are changed #134

Closed
iggybotes opened this issue Feb 17, 2020 · 3 comments
Closed

Trigger onchanges when attributes are changed #134

iggybotes opened this issue Feb 17, 2020 · 3 comments

Comments

@iggybotes
Copy link

iggybotes commented Feb 17, 2020 •
edited

More of a feature request but are you able to trigger this._insertSVG(); when input: setSVGAttributes is changed? This will allow people to dynamically change the width and height of the icon (and possibly other attributes).

if (changes['inlineSVG'] || changes['setSVGAttributes']) {
      this._insertSVG();
    }
@arkon arkon closed this as completed in 7c0d22c May 30, 2020
@qubiack
Copy link

qubiack commented Oct 12, 2020

This was closed without any conclusion?

@arkon
Copy link
Owner

arkon commented Oct 12, 2020

It was fixed 4 months ago, which is the referenced commit.

@qubiack
Copy link

qubiack commented Oct 12, 2020

@arkon sorry - my fault. Thanks for the quick response guy! Great job.

brnomendes added a commit to brnomendes/ng-inline-svg that referenced this issue Dec 29, 2020
@brnomendes
Process SVG on attr changing even if SVG url not changed arkon#134
75002a0
arkon pushed a commit that referenced this issue Jan 5, 2021
@brnomendes
Process SVG on attr changing even if SVG url not changed #134 (#156)
433ec11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@arkon @qubiack @iggybotes