Skip to content
This repository has been archived by the owner on Nov 16, 2021. It is now read-only.

149 - Don't silence HTTP errors in SVGCacheService #180

Merged
merged 1 commit into from
Sep 25, 2021
Merged

149 - Don't silence HTTP errors in SVGCacheService #180

merged 1 commit into from
Sep 25, 2021

Conversation

JohnKis
Copy link
Contributor

@JohnKis JohnKis commented Sep 24, 2021 •
edited

Instead of using the finalize operator which will make the observable always succeed, use tap and catchError to delete the in progress request, while ensuring that HTTP errors will be logged on the onSVGFailed output.

Fixes #149

@JohnKis
Copy link
Contributor Author

JohnKis commented Sep 24, 2021

Fixes #149

@arkon arkon merged commit 05e53a4 into arkon:master Sep 25, 2021
@arkon
Copy link
Owner

arkon commented Sep 25, 2021

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exception when fetching fails
2 participants
@JohnKis @arkon