fix #7

arkphp · Mar 9, 2016 · 200f58d · 200f58d
1 parent 43c19d9
commit 200f58d
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 2 deletions.
diff --git a/src/QueryBuilder.php b/src/QueryBuilder.php
@@ -700,8 +700,8 @@ public function update($table, $values, $conditions, $params = array()){
             if (is_integer($k)) {
                 $updates[] = $value;
             } else {
-                $updates[] = $this->db->quoteColumn($k).' = :'.$k;
-                $params[':'.$k] = $value;
+                $updates[] = $this->db->quoteColumn($k).' = :__'.$k;
+                $params[':__'.$k] = $value;
             }
         }
 

diff --git a/tests/DatabaseTest.php b/tests/DatabaseTest.php
@@ -187,4 +187,31 @@ public function testDangerousDelete() {
 
     public function testTransaction(){
     }
+
+    public function testUpdateParam() {
+        $id = $this->db->builder()
+            ->insert('{{contact}}', [
+                'name' => 'user1',
+                'email' => 'user1@example.com',
+                'point' => 10,
+            ]);
+
+        $affected = $this->db->builder()
+            ->update('{{contact}}', [
+                'point' => 5,
+            ], 'id = :id AND point = :point', [
+                ':id' => $id,
+                ':point' => 10,
+            ]);
+
+        $this->assertEquals(1, $affected);
+
+        $result = $this->db->builder()
+            ->select('point')
+            ->from('{{contact}}')
+            ->where('id = ?', [$id])
+            ->queryValue();
+
+        $this->assertEquals(5, $result);
+    }
 }