Improve bluealsa_delay heuristics #231
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current method can be quite uneven when reporting buffer fullness. VLC is confused by this and keeps dropping in and out of avsync recovery. This patch provides a more even response which VLC likes better.
|
Many thanks for this PR, I will try to review and test it in the next week or two. |
|
Is there any chance this could get merged into the released code at some point? It's particularly important for Raspberry Pi, as VLC used with Bluetooth is basically broken without it. Many thanks. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current method can be quite uneven when reporting buffer fullness.
VLC is confused by this and keeps dropping in and out of avsync
recovery. This patch provides a more even response which VLC likes
better.