Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to use with requirements in sub-folders #28

Closed
philjnicholls opened this issue Sep 28, 2020 · 1 comment
Closed

Unable to use with requirements in sub-folders #28

philjnicholls opened this issue Sep 28, 2020 · 1 comment

Comments

@philjnicholls
Copy link
Contributor

My project uses the common pattern of:

+-- requirements.txt
+-- requirements
| +-- common.txt
| +-- production.txt
| +-- test.txt
| +-- development.txt

requirements.txt includes production.txt which in turn includes common.txt.

When I run flake8 all my requirements show up as I900 Not listed as a requirement.

It seems that resolve_requirement won't handle -r includes with a relative path which I think is necessary for pip to be happy.

So the app finds requirements.txt, includes production.txt thanks to '-r requirements/production.txt' but fails when trying to include common.txt as the line from production.txt is '-r common.txt'.

Am I missing something or is this something you'd be happy for me to work on a PR for?

@arkq
Copy link
Owner

arkq commented Sep 29, 2020 via email

@arkq arkq closed this as completed in 279f21e Oct 1, 2020
arkq pushed a commit that referenced this issue Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants