Ignore some options in requirements.txt #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pip documentation has finally been updated for requirements.txt format specification. Some of the options don't appear to be relevant to what flake8-requirements is doing. Other options could also potentially be ignored, or may require special handling to implement support for them in flake8-requirements. https://pip.pypa.io/en/stable/reference/pip_install/#requirements-file-format https://pip.pypa.io/en/stable/news/#improved-documentation pypa/pip#7385 Partially fixes #9
|
Thanks for this PR, but I think that some more general solution has to be developed. Currently I'm working on this issue. I hope that within this week I will manage to finish it. At first I thought about using requirements-parser package, but the owner seeks maintainer, and there are some issues with parsing. And like you said, this linter does not need to extract all info from requirements.txt file. Hence, I've decided to stick with buildin "parser". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pip documentation has finally been updated for requirements.txt format specification. Some of the options don't appear to be relevant to what flake8-requirements is doing. Other options could also potentially be ignored, or may require special handling to implement support for them in flake8-requirements.
https://pip.pypa.io/en/stable/reference/pip_install/#requirements-file-format
https://pip.pypa.io/en/stable/news/#improved-documentation
pypa/pip#7385
Partially fixes #9