Correctly ignore comment lines #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correctly ignore comment lines following a line continuation character at the end of the previous line. Fixes #14
atugushev
reviewed
Feb 12, 2020
| @@ -73,6 +73,8 @@ def joinlines(lines): | |||
| joined_line = "" | |||
| for line in map(lambda x: x.strip(), lines): | |||
| if not line or line.startswith("#"): | |||
| yield joined_line | |||
| joined_line = "" | |||
| continue | |||
| if line.endswith("\\"): | |||
There was a problem hiding this comment.
I think if-blocks on 75 and 79 lines could be swapped which would fix the issue, the same as pip does.
There was a problem hiding this comment.
Yes, you are righ, that would make flake8-requirements work like pip. But there is a documentation for requirements.txt file which explicitly says "comments are stripped before line continuations are processed". So either documentation is wrong, or pip implementation....
There was a problem hiding this comment.
I just saw the talk on pypa/pip, so when the issue pypa/pip/issues/7728 will be answered, I will follow accordingly :)
|
Any changes I need to make to this PR @arkq, or will you fix it in a new commit ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correctly ignore comment lines following a line continuation character at the end of the previous line.
Fixes #14