Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why are we maintaining our own version of unroll? #33

Closed
jon-chuang opened this issue Nov 12, 2020 · 2 comments
Closed

Why are we maintaining our own version of unroll? #33

jon-chuang opened this issue Nov 12, 2020 · 2 comments

Comments

@jon-chuang
Copy link
Contributor

Yes, the crate dev is not responsive, but are there really necessary changes?
@Pratyush
Copy link
Member

The version on crates.io has an old version of syn and quote, both of which have sizable contributions to compile time. I've submitted a PR to the repo, but it has stagnated for a few months now.

Also, I would prefer to avoid a relatively unmaintained third party dependency in a critical part of the code

@jon-chuang
Copy link
Contributor Author

I see, thanks

mmagician referenced this issue in mmagician/algebra Jan 13, 2022
Merge pull request #33 from w3f/hash_to_curve_wb_with_ietf_parity
bcc53f5 
- match definition of parity function to sgn0 of ietf draft in swu map
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Pratyush @jon-chuang