Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistency between code and documentation #648

Closed
hujw77 opened this issue May 4, 2023 · 0 comments · Fixed by #652
Closed

Inconsistency between code and documentation #648

hujw77 opened this issue May 4, 2023 · 0 comments · Fixed by #652

Comments

@hujw77
Copy link
Contributor

hujw77 commented May 4, 2023

https://github.com/arkworks-rs/algebra/blob/2f9556fe532831538320db3e673af43d8e5627ff/ec/src/models/short_weierstrass/mod.rs#LL65C1-L75C6

The doc says checks if the result is one.
But the code checks the result is zero.
@hujw77 hujw77 mentioned this issue May 26, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix comments hujw77/algebra
1 participant
@hujw77