Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use one transcript for both main code and LDT code #4

Closed
4 tasks done
tsunrise opened this issue Oct 5, 2021 · 0 comments · Fixed by #7
Closed
4 tasks done

Use one transcript for both main code and LDT code #4

tsunrise opened this issue Oct 5, 2021 · 0 comments · Fixed by #7
Labels
Blocking This issue blocks other from progress. Need to be done as soon as possible. D-medium Difficulty: medium P-high Priority: high T-refactor Type: cleanup/refactor
Milestone

Comments

@tsunrise
Copy link
Member

tsunrise commented Oct 5, 2021

Problem Definition

For now, in BCS algorithm, LDT uses a separate transcript, and keeps a mutable reference of all oracles in another transcript. This is counterintuitive because the LDT algorithm is querying some oracles outside its own transcript.

Proposal

In the future, we can let both use same transcript. Instead of giving a Vec<&mut Oracle> to LDT, we can just give them Vec<MsgRoundRef>, which can make code much easier to understand.

Blocking: #6


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@tsunrise tsunrise added Blocking This issue blocks other from progress. Need to be done as soon as possible. D-hard Difficulty: hard P-high Priority: high T-refactor Type: cleanup/refactor D-medium Difficulty: medium and removed D-hard Difficulty: hard labels Oct 16, 2021
@tsunrise tsunrise added this to the Work In Progress milestone Oct 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocking This issue blocks other from progress. Need to be done as soon as possible. D-medium Difficulty: medium P-high Priority: high T-refactor Type: cleanup/refactor
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant