Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circle representation #760

Closed
gerdvogel opened this issue Nov 3, 2019 · 2 comments
Closed

Circle representation #760

gerdvogel opened this issue Nov 3, 2019 · 2 comments

Comments

@gerdvogel
Copy link
Contributor

Circle representation
did a small test, because a circle is not displayed completely in GRBLlaser. The NC file contains only one circle and consists of three segments. The circle is truncated in the representation, this happens whenever a circle is the largest element.

(Projekt circle test)
(Erstellt mit Estlcam Version 11 Build 11,117)
(Laufzeit ca. 00:05:52 Stunden)

(Benoetigte Werkzeuge:)
(Laser)
G21
G90
G94
M04 S1000

(Nr. 144: Gravur 4)
G00 X31.9510 Y0.1645
G02 X-16.0938 Y-27.6812 I-32.0607 J-0.0535 F900
G02 X-16.1865 Y27.8496 I15.9840 J27.7922
G02 X31.9510 Y0.1645 I16.0767 J-27.7386

G00 X0.0000 Y0.0000

M05
M30

Regards Gerd

Circle Test

@arkypita
Copy link
Owner

arkypita commented Nov 3, 2019

Hi Gerd. You are right, but this is a known issue.

The way LaserGRBL use to compute the size boundaries is to compute the X-Max / X-Min and Y-Max / Y-Min by using the X/Y values in each GCode lines.

This is good for G1 linear movement, but it is not ok for G2/G3 arcs where X/Y only represent the target point of movement, not really the farest/nearest point reached by the arc.

This cause a very small error when tracing big images rich of small segments/arcs, so it is not an issue in those cases (only a good approximation) but gives a big error when using small sequence of GCode with big arcs segments.

I can use more complex math (sin/cos/tan etc) to compute the right values when processing G2/G3
but i am not sure that the result is worth the effort.

@gerdvogel
Copy link
Contributor Author

gerdvogel commented Nov 5, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants