Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ui] add light/dark mode selector #23

Closed
arl opened this issue Oct 27, 2020 · 1 comment · Fixed by #108
Closed

[ui] add light/dark mode selector #23

arl opened this issue Oct 27, 2020 · 1 comment · Fixed by #108
Assignees
@tommyblue
Labels
enhancement New feature or request frontend Frontend-related issues (UI / javascript) good first issue Good for newcomers

Comments

@arl
Copy link
Owner

arl commented Oct 27, 2020 •
edited
Loading

Add a dark/light mode switch to the top menu.

The thing is to also change the plot background color when in dark mode.

Bonus point: use system setting, if exists
@arl arl added enhancement New feature or request good first issue Good for newcomers frontend Frontend-related issues (UI / javascript) labels Oct 27, 2020
@arl arl changed the title UI: add light/dark mode selector [ui] add light/dark mode selector Mar 30, 2022
@tommyblue
Copy link
Contributor

tommyblue commented Apr 27, 2023 •
edited
Loading

living a trace here: one of the ploty conf that could do the job is layout.plot_bgcolor and it's currently set here

tommyblue added a commit to tommyblue/statsviz that referenced this issue Apr 28, 2023
@tommyblue
Add dark/light mode
01a62ae 
Add support for dark/light theme

The browser theme is initially used. A switch in the navbar let the user choose their theme. The selection is saved into localStorage for persistency

Fixes arl#23
@tommyblue tommyblue mentioned this issue Apr 28, 2023
Merged
@arl arl closed this as completed in #108 Apr 30, 2023
arl pushed a commit that referenced this issue Apr 30, 2023
@tommyblue
Add dark/light mode (#108)
cca6221 
Add support for dark/light theme

The browser theme is initially used. A switch in the navbar let the user choose their theme. The selection is saved into localStorage for persistency

Fixes #23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tommyblue tommyblue

Labels
enhancement New feature or request frontend Frontend-related issues (UI / javascript) good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add dark/light mode tommyblue/statsviz
2 participants
@tommyblue @arl