feat: only optionally pass username and password

arlac77 · Jul 4, 2017 · 5bcca6b · 5bcca6b
1 parent ac0f302
commit 5bcca6b
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 5 deletions.
diff --git a/src/sftp-scheme.js b/src/sftp-scheme.js
@@ -46,12 +46,19 @@ export default class SFTPScheme extends URLScheme {
       url = new URL(url);
       const sftp = new Client();
 
-      const conn = await sftp.connect({
+      const co = {
         host: url.host,
-        port: url.port || this.constructor.defaultPort,
-        username: url.username,
-        password: '******'
-      });
+        port: url.port || this.constructor.defaultPort
+      };
+
+      if (url.username !== undefined) {
+        co.username = url.username;
+      }
+      if (url.password !== undefined) {
+        co.password = url.password;
+      }
+
+      const conn = await sftp.connect(co);
 
       return conn.get(url.pathname);
     }

diff --git a/tests/sftp-test.js b/tests/sftp-test.js
@@ -2,6 +2,7 @@ import test from 'ava';
 import SFTPScheme from '../src/sftp-scheme';
 
 const url = require('url');
+const path = require('path');
 
 test('has name', t => {
   const scheme = new SFTPScheme();
@@ -17,3 +18,12 @@ test('default port', t => {
   const scheme = new SFTPScheme();
   t.is(scheme.defaultPort, 22);
 });
+
+test('get', async t => {
+  const scheme = new SFTPScheme();
+  const content = await scheme.get(
+    'sftp://localhost/' + path.join(__dirname, '..', 'tests', 'sftp-test.js')
+  );
+
+  t.is(content, 'XXX');
+});