Skip to content

Commit

Permalink
Merge pull request #530 from mzeitlin11/remove_id_prefixes
Browse files Browse the repository at this point in the history
Remove prefix validation from ids
  • Loading branch information
mzeitlin11 committed Apr 10, 2024
2 parents 562c493 + 3adceac commit 7686a0b
Show file tree
Hide file tree
Showing 72 changed files with 90 additions and 423 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -32,4 +32,4 @@ impl stripe_types::Object for BillingPortalConfiguration {
&self.id
}

Check warning on line 33 in generated/stripe_billing/src/billing_portal_configuration/types.rs

View check run for this annotation

Codecov / codecov/patch

generated/stripe_billing/src/billing_portal_configuration/types.rs#L31-L33

Added lines #L31 - L33 were not covered by tests
}
stripe_types::def_id!(BillingPortalConfigurationId, "bpc_");
stripe_types::def_id!(BillingPortalConfigurationId);
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ impl stripe_types::Object for BillingPortalSession {
&self.id
}

Check warning on line 47 in generated/stripe_billing/src/billing_portal_session/types.rs

View check run for this annotation

Codecov / codecov/patch

generated/stripe_billing/src/billing_portal_session/types.rs#L45-L47

Added lines #L45 - L47 were not covered by tests
}
stripe_types::def_id!(BillingPortalSessionId, "bps_");
stripe_types::def_id!(BillingPortalSessionId);
#[derive(Copy, Clone, Eq, PartialEq)]

Check warning on line 50 in generated/stripe_billing/src/billing_portal_session/types.rs

View check run for this annotation

Codecov / codecov/patch

generated/stripe_billing/src/billing_portal_session/types.rs#L50

Added line #L50 was not covered by tests
#[non_exhaustive]
pub enum BillingPortalSessionLocale {
Expand Down
2 changes: 1 addition & 1 deletion generated/stripe_billing/src/usage_record/types.rs
Original file line number Diff line number Diff line change
Expand Up @@ -23,4 +23,4 @@ impl stripe_types::Object for UsageRecord {
&self.id
}

Check warning on line 24 in generated/stripe_billing/src/usage_record/types.rs

View check run for this annotation

Codecov / codecov/patch

generated/stripe_billing/src/usage_record/types.rs#L22-L24

Added lines #L22 - L24 were not covered by tests
}
stripe_types::def_id!(UsageRecordId, "mbur_");
stripe_types::def_id!(UsageRecordId);
2 changes: 1 addition & 1 deletion generated/stripe_checkout/src/checkout_session/types.rs
Original file line number Diff line number Diff line change
Expand Up @@ -329,7 +329,7 @@ impl stripe_types::Object for CheckoutSession {
&self.id
}

Check warning on line 330 in generated/stripe_checkout/src/checkout_session/types.rs

View check run for this annotation

Codecov / codecov/patch

generated/stripe_checkout/src/checkout_session/types.rs#L328-L330

Added lines #L328 - L330 were not covered by tests
}
stripe_types::def_id!(CheckoutSessionId, "cs_");
stripe_types::def_id!(CheckoutSessionId);
#[derive(Copy, Clone, Eq, PartialEq)]

Check warning on line 333 in generated/stripe_checkout/src/checkout_session/types.rs

View check run for this annotation

Codecov / codecov/patch

generated/stripe_checkout/src/checkout_session/types.rs#L333

Added line #L333 was not covered by tests
pub enum CheckoutSessionBillingAddressCollection {
Auto,
Expand Down
2 changes: 1 addition & 1 deletion generated/stripe_misc/src/ephemeral_key/types.rs
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,4 @@ impl stripe_types::Object for EphemeralKey {
&self.id
}
}
stripe_types::def_id!(EphemeralKeyId, "ephkey_");
stripe_types::def_id!(EphemeralKeyId);
2 changes: 1 addition & 1 deletion generated/stripe_misc/src/scheduled_query_run/types.rs
Original file line number Diff line number Diff line change
Expand Up @@ -33,4 +33,4 @@ impl stripe_types::Object for ScheduledQueryRun {
&self.id
}
}
stripe_types::def_id!(ScheduledQueryRunId, "sqr_");
stripe_types::def_id!(ScheduledQueryRunId);
2 changes: 1 addition & 1 deletion generated/stripe_misc/src/webhook_endpoint/types.rs
Original file line number Diff line number Diff line change
Expand Up @@ -42,4 +42,4 @@ impl stripe_types::Object for WebhookEndpoint {
&self.id
}
}
stripe_types::def_id!(WebhookEndpointId, "we_");
stripe_types::def_id!(WebhookEndpointId);
2 changes: 1 addition & 1 deletion generated/stripe_shared/src/account.rs
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ impl stripe_types::Object for Account {
&self.id
}
}
stripe_types::def_id!(AccountId, "acct_");
stripe_types::def_id!(AccountId);
#[derive(Copy, Clone, Eq, PartialEq)]
pub enum AccountBusinessType {
Company,
Expand Down
2 changes: 1 addition & 1 deletion generated/stripe_shared/src/application.rs
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,4 @@ impl stripe_types::Object for Application {
&self.id
}
}
stripe_types::def_id!(ApplicationId, "ca_");
stripe_types::def_id!(ApplicationId);
2 changes: 1 addition & 1 deletion generated/stripe_shared/src/application_fee.rs
Original file line number Diff line number Diff line change
Expand Up @@ -36,4 +36,4 @@ impl stripe_types::Object for ApplicationFee {
&self.id
}
}
stripe_types::def_id!(ApplicationFeeId, "fee_");
stripe_types::def_id!(ApplicationFeeId);
2 changes: 1 addition & 1 deletion generated/stripe_shared/src/application_fee_refund.rs
Original file line number Diff line number Diff line change
Expand Up @@ -30,4 +30,4 @@ impl stripe_types::Object for ApplicationFeeRefund {
&self.id
}
}
stripe_types::def_id!(ApplicationFeeRefundId, "fr_");
stripe_types::def_id!(ApplicationFeeRefundId);
2 changes: 1 addition & 1 deletion generated/stripe_shared/src/balance_transaction.rs
Original file line number Diff line number Diff line change
Expand Up @@ -225,4 +225,4 @@ impl stripe_types::Object for BalanceTransaction {
&self.id
}
}
stripe_types::def_id!(BalanceTransactionId, "txn_");
stripe_types::def_id!(BalanceTransactionId);
2 changes: 1 addition & 1 deletion generated/stripe_shared/src/bank_account.rs
Original file line number Diff line number Diff line change
Expand Up @@ -130,4 +130,4 @@ impl stripe_types::Object for BankAccount {
&self.id
}
}
stripe_types::def_id!(BankAccountId, "ba_" | "card_");
stripe_types::def_id!(BankAccountId);
2 changes: 1 addition & 1 deletion generated/stripe_shared/src/card.rs
Original file line number Diff line number Diff line change
Expand Up @@ -159,4 +159,4 @@ impl stripe_types::Object for Card {
&self.id
}
}
stripe_types::def_id!(CardId, "card_");
stripe_types::def_id!(CardId);
2 changes: 1 addition & 1 deletion generated/stripe_shared/src/charge.rs
Original file line number Diff line number Diff line change
Expand Up @@ -189,4 +189,4 @@ impl stripe_types::Object for Charge {
&self.id
}
}
stripe_types::def_id!(ChargeId, "ch_" | "py_");
stripe_types::def_id!(ChargeId);
2 changes: 1 addition & 1 deletion generated/stripe_shared/src/checkout_session_item.rs
Original file line number Diff line number Diff line change
Expand Up @@ -35,4 +35,4 @@ impl stripe_types::Object for CheckoutSessionItem {
&self.id
}
}
stripe_types::def_id!(CheckoutSessionItemId, "li_");
stripe_types::def_id!(CheckoutSessionItemId);
2 changes: 1 addition & 1 deletion generated/stripe_shared/src/connect_collection_transfer.rs
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,4 @@ impl stripe_types::Object for ConnectCollectionTransfer {
&self.id
}
}
stripe_types::def_id!(ConnectCollectionTransferId, "connct_");
stripe_types::def_id!(ConnectCollectionTransferId);
2 changes: 1 addition & 1 deletion generated/stripe_shared/src/credit_note.rs
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ impl stripe_types::Object for CreditNote {
&self.id
}
}
stripe_types::def_id!(CreditNoteId, "cn_");
stripe_types::def_id!(CreditNoteId);
#[derive(Copy, Clone, Eq, PartialEq)]
pub enum CreditNoteReason {
Duplicate,
Expand Down
2 changes: 1 addition & 1 deletion generated/stripe_shared/src/credit_note_line_item.rs
Original file line number Diff line number Diff line change
Expand Up @@ -98,4 +98,4 @@ impl stripe_types::Object for CreditNoteLineItem {
&self.id
}
}
stripe_types::def_id!(CreditNoteLineItemId, "cnli_");
stripe_types::def_id!(CreditNoteLineItemId);
2 changes: 1 addition & 1 deletion generated/stripe_shared/src/customer.rs
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ impl stripe_types::Object for Customer {
&self.id
}
}
stripe_types::def_id!(CustomerId, "cus_");
stripe_types::def_id!(CustomerId);
#[derive(Copy, Clone, Eq, PartialEq)]
pub enum CustomerTaxExempt {
Exempt,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -126,4 +126,4 @@ impl stripe_types::Object for CustomerBalanceTransaction {
&self.id
}
}
stripe_types::def_id!(CustomerBalanceTransactionId, "cbtxn_");
stripe_types::def_id!(CustomerBalanceTransactionId);
2 changes: 1 addition & 1 deletion generated/stripe_shared/src/discount.rs
Original file line number Diff line number Diff line change
Expand Up @@ -36,4 +36,4 @@ impl stripe_types::Object for Discount {
&self.id
}
}
stripe_types::def_id!(DiscountId, "di_");
stripe_types::def_id!(DiscountId);
2 changes: 1 addition & 1 deletion generated/stripe_shared/src/dispute.rs
Original file line number Diff line number Diff line change
Expand Up @@ -121,4 +121,4 @@ impl stripe_types::Object for Dispute {
&self.id
}
}
stripe_types::def_id!(DisputeId, "dp_" | "du_" | "pdp_");
stripe_types::def_id!(DisputeId);
2 changes: 1 addition & 1 deletion generated/stripe_shared/src/event.rs
Original file line number Diff line number Diff line change
Expand Up @@ -829,4 +829,4 @@ impl stripe_types::Object for Event {
&self.id
}
}
stripe_types::def_id!(EventId, "evt_");
stripe_types::def_id!(EventId);
2 changes: 1 addition & 1 deletion generated/stripe_shared/src/file.rs
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ impl stripe_types::Object for File {
&self.id
}
}
stripe_types::def_id!(FileId, "file_");
stripe_types::def_id!(FileId);
#[derive(Copy, Clone, Eq, PartialEq)]
#[non_exhaustive]
pub enum FilePurpose {
Expand Down
2 changes: 1 addition & 1 deletion generated/stripe_shared/src/file_link.rs
Original file line number Diff line number Diff line change
Expand Up @@ -29,4 +29,4 @@ impl stripe_types::Object for FileLink {
&self.id
}
}
stripe_types::def_id!(FileLinkId, "link_");
stripe_types::def_id!(FileLinkId);
2 changes: 1 addition & 1 deletion generated/stripe_shared/src/invoice.rs
Original file line number Diff line number Diff line change
Expand Up @@ -422,7 +422,7 @@ impl stripe_types::Object for Invoice {
&self.id
}
}
stripe_types::def_id!(InvoiceId, "in_");
stripe_types::def_id!(InvoiceId);
#[derive(Copy, Clone, Eq, PartialEq)]
pub enum InvoiceCollectionMethod {
ChargeAutomatically,
Expand Down
2 changes: 1 addition & 1 deletion generated/stripe_shared/src/invoice_item.rs
Original file line number Diff line number Diff line change
Expand Up @@ -75,4 +75,4 @@ impl stripe_types::Object for InvoiceItem {
&self.id
}
}
stripe_types::def_id!(InvoiceItemId, "ii_");
stripe_types::def_id!(InvoiceItemId);
2 changes: 1 addition & 1 deletion generated/stripe_shared/src/issuing_authorization.rs
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ impl stripe_types::Object for IssuingAuthorization {
&self.id
}
}
stripe_types::def_id!(IssuingAuthorizationId, "iauth_");
stripe_types::def_id!(IssuingAuthorizationId);
#[derive(Copy, Clone, Eq, PartialEq)]
pub enum IssuingAuthorizationAuthorizationMethod {
Chip,
Expand Down
2 changes: 1 addition & 1 deletion generated/stripe_shared/src/issuing_card.rs
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ impl stripe_types::Object for IssuingCard {
&self.id
}
}
stripe_types::def_id!(IssuingCardId, "ic_");
stripe_types::def_id!(IssuingCardId);
#[derive(Copy, Clone, Eq, PartialEq)]
pub enum IssuingCardReplacementReason {
Damaged,
Expand Down
2 changes: 1 addition & 1 deletion generated/stripe_shared/src/issuing_cardholder.rs
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ impl stripe_types::Object for IssuingCardholder {
&self.id
}
}
stripe_types::def_id!(IssuingCardholderId, "ich_");
stripe_types::def_id!(IssuingCardholderId);
#[derive(Copy, Clone, Eq, PartialEq)]
pub enum IssuingCardholderPreferredLocales {
De,
Expand Down
2 changes: 1 addition & 1 deletion generated/stripe_shared/src/issuing_dispute.rs
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ impl stripe_types::Object for IssuingDispute {
&self.id
}
}
stripe_types::def_id!(IssuingDisputeId, "idp_");
stripe_types::def_id!(IssuingDisputeId);
#[derive(Copy, Clone, Eq, PartialEq)]
pub enum IssuingDisputeStatus {
Expired,
Expand Down
2 changes: 1 addition & 1 deletion generated/stripe_shared/src/issuing_transaction.rs
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ impl stripe_types::Object for IssuingTransaction {
&self.id
}
}
stripe_types::def_id!(IssuingTransactionId, "ipi_");
stripe_types::def_id!(IssuingTransactionId);
#[derive(Copy, Clone, Eq, PartialEq)]
pub enum IssuingTransactionType {
Capture,
Expand Down
2 changes: 1 addition & 1 deletion generated/stripe_shared/src/mandate.rs
Original file line number Diff line number Diff line change
Expand Up @@ -139,4 +139,4 @@ impl stripe_types::Object for Mandate {
&self.id
}
}
stripe_types::def_id!(MandateId, "mandate_");
stripe_types::def_id!(MandateId);
2 changes: 1 addition & 1 deletion generated/stripe_shared/src/payment_intent.rs
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,7 @@ impl stripe_types::Object for PaymentIntent {
&self.id
}
}
stripe_types::def_id!(PaymentIntentId, "pi_");
stripe_types::def_id!(PaymentIntentId);
#[derive(Copy, Clone, Eq, PartialEq)]
pub enum PaymentIntentCaptureMethod {
Automatic,
Expand Down
2 changes: 1 addition & 1 deletion generated/stripe_shared/src/payment_link.rs
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ impl stripe_types::Object for PaymentLink {
&self.id
}
}
stripe_types::def_id!(PaymentLinkId, "plink_");
stripe_types::def_id!(PaymentLinkId);
#[derive(Copy, Clone, Eq, PartialEq)]
pub enum PaymentLinkBillingAddressCollection {
Auto,
Expand Down
2 changes: 1 addition & 1 deletion generated/stripe_shared/src/payment_method.rs
Original file line number Diff line number Diff line change
Expand Up @@ -262,4 +262,4 @@ impl stripe_types::Object for PaymentMethod {
&self.id
}
}
stripe_types::def_id!(PaymentMethodId, "pm_" | "card_" | "src_" | "ba_");
stripe_types::def_id!(PaymentMethodId);
2 changes: 1 addition & 1 deletion generated/stripe_shared/src/payout.rs
Original file line number Diff line number Diff line change
Expand Up @@ -182,4 +182,4 @@ impl stripe_types::Object for Payout {
&self.id
}
}
stripe_types::def_id!(PayoutId, "po_");
stripe_types::def_id!(PayoutId);
2 changes: 1 addition & 1 deletion generated/stripe_shared/src/person.rs
Original file line number Diff line number Diff line change
Expand Up @@ -154,4 +154,4 @@ impl stripe_types::Object for Person {
&self.id
}
}
stripe_types::def_id!(PersonId, "person_");
stripe_types::def_id!(PersonId);
2 changes: 1 addition & 1 deletion generated/stripe_shared/src/platform_tax_fee.rs
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,4 @@ impl stripe_types::Object for PlatformTaxFee {
&self.id
}
}
stripe_types::def_id!(PlatformTaxFeeId, "ptf_");
stripe_types::def_id!(PlatformTaxFeeId);
2 changes: 1 addition & 1 deletion generated/stripe_shared/src/price.rs
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ impl stripe_types::Object for Price {
&self.id
}
}
stripe_types::def_id!(PriceId, "price_" | "plan_");
stripe_types::def_id!(PriceId);
#[derive(Copy, Clone, Eq, PartialEq)]
pub enum PriceBillingScheme {
PerUnit,
Expand Down
2 changes: 1 addition & 1 deletion generated/stripe_shared/src/promotion_code.rs
Original file line number Diff line number Diff line change
Expand Up @@ -37,4 +37,4 @@ impl stripe_types::Object for PromotionCode {
&self.id
}
}
stripe_types::def_id!(PromotionCodeId, "promo_");
stripe_types::def_id!(PromotionCodeId);
2 changes: 1 addition & 1 deletion generated/stripe_shared/src/quote.rs
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ impl stripe_types::Object for Quote {
&self.id
}
}
stripe_types::def_id!(QuoteId, "qt_");
stripe_types::def_id!(QuoteId);
#[derive(Copy, Clone, Eq, PartialEq)]
pub enum QuoteCollectionMethod {
ChargeAutomatically,
Expand Down
2 changes: 1 addition & 1 deletion generated/stripe_shared/src/refund.rs
Original file line number Diff line number Diff line change
Expand Up @@ -124,4 +124,4 @@ impl stripe_types::Object for Refund {
&self.id
}
}
stripe_types::def_id!(RefundId, "re_" | "pyr_");
stripe_types::def_id!(RefundId);
2 changes: 1 addition & 1 deletion generated/stripe_shared/src/reserve_transaction.rs
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,4 @@ impl stripe_types::Object for ReserveTransaction {
&self.id
}
}
stripe_types::def_id!(ReserveTransactionId, "rtx_");
stripe_types::def_id!(ReserveTransactionId);
2 changes: 1 addition & 1 deletion generated/stripe_shared/src/review.rs
Original file line number Diff line number Diff line change
Expand Up @@ -161,4 +161,4 @@ impl stripe_types::Object for Review {
&self.id
}
}
stripe_types::def_id!(ReviewId, "prv_");
stripe_types::def_id!(ReviewId);
2 changes: 1 addition & 1 deletion generated/stripe_shared/src/setup_attempt.rs
Original file line number Diff line number Diff line change
Expand Up @@ -106,4 +106,4 @@ impl stripe_types::Object for SetupAttempt {
&self.id
}
}
stripe_types::def_id!(SetupAttemptId, "setatt_");
stripe_types::def_id!(SetupAttemptId);
2 changes: 1 addition & 1 deletion generated/stripe_shared/src/setup_intent.rs
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ impl stripe_types::Object for SetupIntent {
&self.id
}
}
stripe_types::def_id!(SetupIntentId, "seti_");
stripe_types::def_id!(SetupIntentId);
#[derive(Copy, Clone, Eq, PartialEq)]
pub enum SetupIntentCancellationReason {
Abandoned,
Expand Down
2 changes: 1 addition & 1 deletion generated/stripe_shared/src/shipping_rate.rs
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ impl stripe_types::Object for ShippingRate {
&self.id
}
}
stripe_types::def_id!(ShippingRateId, "shr_");
stripe_types::def_id!(ShippingRateId);
#[derive(Copy, Clone, Eq, PartialEq)]
pub enum ShippingRateTaxBehavior {
Exclusive,
Expand Down
2 changes: 1 addition & 1 deletion generated/stripe_shared/src/source.rs
Original file line number Diff line number Diff line change
Expand Up @@ -221,4 +221,4 @@ impl stripe_types::Object for Source {
&self.id
}
}
stripe_types::def_id!(SourceId, "src_");
stripe_types::def_id!(SourceId);
2 changes: 1 addition & 1 deletion generated/stripe_shared/src/subscription.rs
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ impl stripe_types::Object for Subscription {
&self.id
}
}
stripe_types::def_id!(SubscriptionId, "sub_");
stripe_types::def_id!(SubscriptionId);
#[derive(Copy, Clone, Eq, PartialEq)]
pub enum SubscriptionCollectionMethod {
ChargeAutomatically,
Expand Down
2 changes: 1 addition & 1 deletion generated/stripe_shared/src/subscription_item.rs
Original file line number Diff line number Diff line change
Expand Up @@ -30,4 +30,4 @@ impl stripe_types::Object for SubscriptionItem {
&self.id
}
}
stripe_types::def_id!(SubscriptionItemId, "si_");
stripe_types::def_id!(SubscriptionItemId);
2 changes: 1 addition & 1 deletion generated/stripe_shared/src/subscription_schedule.rs
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ impl stripe_types::Object for SubscriptionSchedule {
&self.id
}
}
stripe_types::def_id!(SubscriptionScheduleId, "sub_sched_");
stripe_types::def_id!(SubscriptionScheduleId);
#[derive(Copy, Clone, Eq, PartialEq)]
pub enum SubscriptionScheduleEndBehavior {
Cancel,
Expand Down
2 changes: 1 addition & 1 deletion generated/stripe_shared/src/tax_code.rs
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,4 @@ impl stripe_types::Object for TaxCode {
&self.id
}
}
stripe_types::def_id!(TaxCodeId, "txcd_");
stripe_types::def_id!(TaxCodeId);
2 changes: 1 addition & 1 deletion generated/stripe_shared/src/tax_deducted_at_source.rs
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,4 @@ impl stripe_types::Object for TaxDeductedAtSource {
&self.id
}
}
stripe_types::def_id!(TaxDeductedAtSourceId, "itds_");
stripe_types::def_id!(TaxDeductedAtSourceId);
2 changes: 1 addition & 1 deletion generated/stripe_shared/src/tax_id.rs
Original file line number Diff line number Diff line change
Expand Up @@ -283,4 +283,4 @@ impl stripe_types::Object for TaxId {
&self.id
}
}
stripe_types::def_id!(TaxIdId, "txi_" | "atxi_");
stripe_types::def_id!(TaxIdId);
Loading

0 comments on commit 7686a0b

Please sign in to comment.