-
-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fn to expire checkout sessions #334
Conversation
Looking at CONTRIBUTING.md. I ran
I am not sure if I am supposed to put a stripe token somewhere so it will let the test talk to it. === I also ran But it seemed to give back a whole bunch of existing warnings that were not related to my change. So I am not sure if that is actively being followed now. |
I'm not sure if taking a mutable reference to a full |
You raise a cool idea. I am interested in maybe supporting a trait that allows the id but consumes the object. Raise an issue and we can track it! :) Regarding tests, a few of them need stripe mock to run properly so I think you're ok. Clippy is a little more complicated, as you need to pick a runtime to lint against. One of the downsides with different feature-based runtimes... I have approved CI now so new commits should run it automatically. Could you prefix your commit message with Thanks! |
Codecov Report
@@ Coverage Diff @@
## master #334 +/- ##
=========================================
- Coverage 6.57% 6.57% -0.01%
=========================================
Files 130 130
Lines 20022 20025 +3
=========================================
Hits 1317 1317
- Misses 18705 18708 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
b818b41
to
0368c79
Compare
@arlyon This should be fixed now. |
All green, thanks for taking the time! :) |
Summary
Fixes #331
Checklist
cargo make fmt