fix(codegen): stripe "terminal" is not an object, but its subpaths are #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgramop
changed the title
|
Note: I didn't run openapi-install before this commit, is that something I should take care of? Not sure what prefer w/r to keeping history clean. Lmk if you'd like me to to run it |
Was trying to generate a terminal connection token, but codegen incorrectly uses terminal as an object (instead of as a resource), leading to requests for terminal objects (like terminal.connection_token) being mislabeled in the map, and those objects not being found when it came time to generate impl's for their requests
dgramop
force-pushed
the
fix_terminal_codegen
branch
from
bbecb90
to
bf7e117
Compare
|
Hey man, I just ran CI, will report back in a little bit. Thanks for taking the time! |
|
Merged! Doing a release today |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was trying to generate a terminal connection token, but codegen incorrectly uses terminal as an object (instead of as a resource), leading to requests for terminal objects (like terminal.connection_token) being mislabeled in the map, and those objects not being found when it came time to generate impl's for their requests
Summary
Checklist
cargo make fmt