Simplify client, remove some allocations #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzeitlin11
commented
Apr 5, 2024
| @@ -138,22 +137,24 @@ struct Signature<'r> { | |||
|
|
|||
| impl<'r> Signature<'r> { | |||
| fn parse(raw: &'r str) -> Result<Signature<'r>, WebhookError> { | |||
| let headers: HashMap<&str, &str> = raw | |||
There was a problem hiding this comment.
Would be a strange attack, but seems good to avoid collecting every pair in the signature since it could be malicious
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #528 +/- ##
========================================
- Coverage 5.71% 5.70% -0.02%
========================================
Files 932 932
Lines 38941 38933 -8
========================================
- Hits 2227 2220 -7
+ Misses 36714 36713 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the big PR in, excited for a small, self-contained PR with some small tweaks I didn't want to mix with everything else