Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interleave error from forcing <method> storage #62

Closed
solidpixel opened this issue Jul 8, 2019 · 1 comment
Closed

Interleave error from forcing <method> storage #62

solidpixel opened this issue Jul 8, 2019 · 1 comment

Comments

@solidpixel
Copy link
Contributor

Analysis shows that we get increased cache pressure in compute_lowest_and_highest_weight because these two:

float error_from_forcing_weight_down[60];
float error_from_forcing_weight_either_way[60];

... are stored as separate arrays and accessed inside a hot loop. We always access the same index in each array at the same time, so we should store this as a single array of structs to reduce cache pressure.

@solidpixel
Copy link
Contributor Author

Rejecting. This helps on older CPUs, but shows no advantage on current generation Core processors (tested on a Core-i5).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant